Cpp master issue 994 #995
Cpp master issue 994 #995
Conversation
The stringification of a msgpack object shouldn't write the
raw bytes of a binary value. It will likely make the result
unprintable. Just print that it's a binary blob and include
the size. E.g.,
{"data":BIN(1032256)}
EXT is handled similarly but without the size. We now also
print the size.
Issue 994
|
Thank you for quick post. |
Solution adjusted as per your feedback. See new commit |
include/msgpack/v1/object.hpp
Outdated
| bool visit_ext(const char* /*v*/, uint32_t /*size*/) { | ||
| m_os << "EXT"; | ||
| bool visit_ext(const char* v, uint32_t size) { | ||
| int type = ((size > 0) && (v[0] >= 0)) ? v[0] : -1; |
There was a problem hiding this comment.
Maybe my comment is misleading. If the value of type is -2 the output should be -2. I mean print as singed.
include/msgpack/v1/object.hpp
Outdated
| m_os << "EXT"; | ||
| bool visit_ext(const char* v, uint32_t size) { | ||
| int type = ((size > 0) && (v[0] >= 0)) ? v[0] : -1; | ||
| m_os << "\"EXT(type:" << type << ",size:" << size << ")\""; |
There was a problem hiding this comment.
See https://github.com/msgpack/msgpack/blob/master/spec.md#ext-format-family
The parameter size is size of type + data.
I think that users expect size of data. So the printed value should size-1.
There was a problem hiding this comment.
So the code should be
bool visit_ext(const char* v, uint32_t size) {
if (size == 0) {
m_os << "\"EXT(size:0)\"";
}
else {
m_os << "\"EXT(type:" << static_cast<int>(v[0]) << ",size:" << size - 1 << ")\"";
}There was a problem hiding this comment.
Got it. Thanks. Will upload a change tomorrow morning.
There was a problem hiding this comment.
NOTE: size==0 on EXT is error. But I choose printing only size. (avoid invalid v[0] access.
Codecov Report
@@ Coverage Diff @@
## cpp_master #995 +/- ##
==============================================
- Coverage 85.60% 85.56% -0.04%
==============================================
Files 79 79
Lines 5007 5009 +2
==============================================
Hits 4286 4286
- Misses 721 723 +2 |
|
I uploaded the EXT implementation you asked for. |
|
Looks good to me. |
|
Thanks for accepting it so quickly! |
No description provided.