Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing MsgPack Nuget for UWP App References libc.dll; Store upload fails #206

Closed
bunkerdives opened this issue Dec 12, 2016 · 2 comments
Closed

Installing MsgPack Nuget for UWP App References libc.dll; Store upload fails #206

bunkerdives opened this issue Dec 12, 2016 · 2 comments
Labels
bug Detected as bug

Comments

@bunkerdives
Copy link

Somewhat similar to Issue #41, we are seeing that installing MsgPack.Cli from Nuget, for a UWP project, results in a dependency on libc.dll. This prevents projects including MsgPack from being capable of Windows Store upload, as compiling with the .NET Native toolchain will fail.

However, compiling the MsgPack source directly DOES result in a MsgPack.dll (Uwp project) which does NOT depend on libc.dll. Perhaps the Nuspec file needs to be updated so that installing via Nuget does not break the UWP store build (thus preventing Store upload)?

Thanks!
@yfakariya yfakariya added the bug Detected as bug label Dec 24, 2016
@yfakariya
Copy link
Member

It is mistake when I introduce .NET Standard. I will fix this. Sorry.

@bunkerdives
Copy link
Author

Thank you! Could you let me know which Nuget version it is fixed in once you fix it!?! Many thanks.

yfakariya added a commit that referenced this issue Feb 11, 2017
@yfakariya
Fix build error.
4be6e7f 
This fixes build errors caused by #205 and #206 change.
yfakariya added a commit that referenced this issue Feb 11, 2017
@yfakariya
Fix build error.
23effe8 
This fixes build errors caused by #205 and #206 change.
yfakariya added a commit that referenced this issue Feb 12, 2017
@yfakariya
Revert "Remove memcmp from MessagePackString. Fix #206."
bf67b3b 
This reverts commit 208c0c7 and a part of 23effe8.
yfakariya added a commit that referenced this issue Feb 12, 2017
@yfakariya
Enable UAP drop for release build and NuGet. #206
7415419 
This solves following .NET Native related issue:
* This build does not contain P/Invoke.
* This build does not contain System.Reflection.Emit.
@DaTester DaTester mentioned this issue Jul 6, 2017
Closed
@DaTester DaTester mentioned this issue Sep 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Detected as bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yfakariya @bunkerdives