Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pregenerated serializer hangs on multidimensional array context creation #81

Closed
internetcoffeephone opened this issue May 12, 2015 · 2 comments
Labels
bug Detected as bug enhancement Requires or request to feature enhancement

Comments

@internetcoffeephone
Copy link

I'm using Unity 5, so I pregenerated the serializers, and now I'm creating the right context. There are no circular references, and I'm adding the serializers to the context in the right order (if that matters).
It hangs there however, to be specific in this part:

public XxxxSerializer(MsgPack.Serialization.SerializationContext context) : 
                base(context) {
            this._serializer0 = context.GetSerializer<Yyyy[,,]>();
        }

Somewhere down the stack trace it seems to be hanging at:

MsgPack.ReflectionAbstractions.GetIsGenericType (source={Yyyy[,,]})
@yfakariya yfakariya added bug Detected as bug enhancement Requires or request to feature enhancement labels Jun 7, 2015
@yfakariya yfakariya added this to the 0.6.1 milestone Jun 7, 2015
@yfakariya
Copy link
Member

Thank you for reporting and sorry for delay.
I have never considered multidimensional array, so it is missing feature.

yfakariya added a commit that referenced this issue Jul 5, 2015
Note: Non-zero bound single dimension arrays should be handled as 1-dimension multi dimensional array. There are no runtime optimization for non-sz array anyway.
@yfakariya
Copy link
Member

Fixed in 0.6.0-beta5 with 1-dimensional array which has non-zero lower-bound.

@yfakariya yfakariya removed this from the 0.6.1 milestone Aug 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Detected as bug enhancement Requires or request to feature enhancement
Projects
None yet
Development

No branches or pull requests

2 participants