Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where process.env does not exists (but process exists) #200

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

gfx
Copy link
Member

@gfx gfx commented Feb 8, 2022

Alternative to #199

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #200 (d81001c) into main (b041a96) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          16       16           
  Lines         964      964           
  Branches      206      206           
=======================================
  Hits          946      946           
  Misses         18       18           
Impacted Files Coverage Δ
src/utils/utf8.ts 95.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b041a96...d81001c. Read the comment docs.

@gfx gfx mentioned this pull request Feb 8, 2022
@gfx gfx merged commit 497a816 into main Feb 8, 2022
@gfx gfx deleted the gfx/process-env-may-not-be-defined branch February 8, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants