Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgpack unpacking does not memoize string keys #372

Closed
cfbolz opened this issue Nov 6, 2019 · 1 comment · Fixed by #381
Closed

msgpack unpacking does not memoize string keys #372

cfbolz opened this issue Nov 6, 2019 · 1 comment · Fixed by #381

Comments

@cfbolz
Copy link

cfbolz commented Nov 6, 2019

In most large msgpack messages, the same kind of object repeats many times, therefore the same keys appear again and again. Many json decoders exploit this and memoize/intern strings, to reduce the memory use of the resulting message and also to reduce decoding time, see for example in PyPy. Would there be interest in implementing this feature in msgpack? I'd be happy to do the implementation work, if so.

@cfbolz
Copy link
Author

cfbolz commented Nov 13, 2019

I had some time so I went ahead and created a pull request: #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant