Skip to content

fix #418 slang and verilator cant run under WSL #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

zoomer-k
Copy link
Contributor

@zoomer-k zoomer-k commented Jun 1, 2023

fix cwd path under WSL
#418

zoomer-k and others added 4 commits June 1, 2023 16:28
add cwdWin for windows
add cwdWin for windows
add unreleased log
@mshr-h
Copy link
Owner

mshr-h commented Jun 1, 2023

@zoomer-k
Replaced cwdWin with path.dirname(docUri).
Please check the new code if it's OK.
Maybe I have to handle them in the base class but it's fine at the moment.

@mshr-h mshr-h merged commit 6648225 into mshr-h:main Jun 1, 2023
mshr-h added a commit that referenced this pull request Jun 1, 2023
@zoomer-k
Copy link
Contributor Author

zoomer-k commented Jun 2, 2023

@mshr-h
its ok
thank you for your review

@mshr-h
Copy link
Owner

mshr-h commented Jun 2, 2023

Released v1.11.5 with this fix.

@zoomer-k zoomer-k deleted the dev_114 branch June 2, 2023 10:09
@zoomer-k
Copy link
Contributor Author

zoomer-k commented Jun 5, 2023

@mshr-h
sorry for my miss

docUri is overwrided if use WSL

   let docUri: string = doc.uri.fsPath;
    let docFolder: string = path.dirname(docUri);
    if (isWindows) {
      if (this.useWSL) {
        docUri = this.convertToWslPath(docUri);
        this.logger.info(`Rewrote docUri to ${docUri} for WSL`);

        docFolder = this.convertToWslPath(docFolder);
        this.logger.info(`Rewrote docFolder to ${docFolder} for WSL`);
      } else {
        docUri = docUri.replace(/\\/g, '/');
        docFolder = docFolder.replace(/\\/g, '/');
      }
    }

so cwd is not changed windows path following code

    let cwd: string = this.runAtFileLocation
      ? isWindows
        ? path.dirname(docUri)
        : docFolder
      : vscode.workspace.workspaceFolders[0].uri.fsPath;

I should have debuged and compiled
I just reviewed

@mshr-h
Copy link
Owner

mshr-h commented Jun 6, 2023

Ok. I've reverted the commit.

@mshr-h
Copy link
Owner

mshr-h commented Jun 8, 2023

Released v1.11.7 with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants