Skip to content

Update typescript-eslint monorepo to v8 (major) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
322 changes: 137 additions & 185 deletions package-lock.json
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -609,8 +609,8 @@
"@types/node": "~22.10.0",
"@types/vscode": "^1.75.0",
"@types/which": "^3.0.3",
"@typescript-eslint/eslint-plugin": "^7.3.1",
"@typescript-eslint/parser": "^7.3.1",
"@typescript-eslint/eslint-plugin": "^8.0.0",
"@typescript-eslint/parser": "^8.0.0",
"@vscode/test-electron": "^2.3.9",
"@vscode/vsce": "~3.1.0",
"antlr4ts-cli": "0.5.0-alpha.4",

Unchanged files with check annotations Beta

// SPDX-License-Identifier: MIT
import * as vscode from 'vscode';
import * as child_process from 'child_process';

Check warning on line 3 in src/providers/FormatPrivider.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Import name `child_process` must match one of the following formats: camelCase, PascalCase

Check warning on line 3 in src/providers/FormatPrivider.ts

GitHub Actions / Upload vsix package (macos-latest)

Import name `child_process` must match one of the following formats: camelCase, PascalCase
import * as fs from 'fs';
import * as os from 'os';
import * as crypto from 'crypto';
}
public readFileSync(
options: BufferEncoding | { encoding: BufferEncoding; flag?: string }

Check warning on line 26 in src/providers/FormatPrivider.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

'BufferEncoding' is not defined

Check warning on line 26 in src/providers/FormatPrivider.ts

GitHub Actions / Upload vsix package (macos-latest)

'BufferEncoding' is not defined
): string {
return fs.readFileSync(this.path, options);
}
// SPDX-License-Identifier: MIT
import * as vscode from 'vscode';
import * as child_process from 'child_process';

Check warning on line 3 in src/linter/XvlogLinter.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Import name `child_process` must match one of the following formats: camelCase, PascalCase

Check warning on line 3 in src/linter/XvlogLinter.ts

GitHub Actions / Upload vsix package (macos-latest)

Import name `child_process` must match one of the following formats: camelCase, PascalCase
import * as path from 'path';
import BaseLinter from './BaseLinter';
import { Logger } from '../logger';
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
import * as child from 'child_process';
import BaseLinter from './BaseLinter';
import { Logger } from '../logger';
var isWindows = process.platform === 'win32';

Check warning on line 7 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

'process' is not defined

Check warning on line 7 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (macos-latest)

'process' is not defined
export default class ModelsimLinter extends BaseLinter {
private modelsimPath: string;
protected lint(doc: vscode.TextDocument) {
this.logger.info('modelsim lint requested');
let docUri: string = doc.uri.fsPath; //path of current doc
let lastIndex: number = isWindows == true ? docUri.lastIndexOf('\\') : docUri.lastIndexOf('/');

Check warning on line 50 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Expected '===' and instead saw '=='

Check warning on line 50 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (macos-latest)

Expected '===' and instead saw '=='
let docFolder = docUri.substr(0, lastIndex); //folder of current doc
let runLocation: string =
this.runAtFileLocation == true ? docFolder : vscode.workspace.rootPath; //choose correct location to run

Check warning on line 53 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Expected '===' and instead saw '=='

Check warning on line 53 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (macos-latest)

Expected '===' and instead saw '=='
// no change needed for systemverilog
let command: string =
this.modelsimPath +
if (line.startsWith('**')) {
try {
let m = line.match(regexExp);
if (m[7] != doc.fileName) {

Check warning on line 79 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Expected '!==' and instead saw '!='

Check warning on line 79 in src/linter/ModelsimLinter.ts

GitHub Actions / Upload vsix package (macos-latest)

Expected '!==' and instead saw '!='
return;
}
let lineNum = parseInt(m[8]) - 1;
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/linter/LintManager.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/linter/LintManager.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
import BaseLinter from './BaseLinter';
import IcarusLinter from './IcarusLinter';
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/linter/IcarusLinter.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/linter/IcarusLinter.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
import * as child from 'child_process';
import * as path from 'path';
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/linter/BaseLinter.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/linter/BaseLinter.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
import * as path from 'path';
import { Logger } from '../logger';
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/hover.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/hover.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
export class HoverProvider implements vscode.HoverProvider {
function getPrefixedComment(document: vscode.TextDocument, lineNo: number) {
let i = lineNo - 1;
let buf = '';
while (true) {

Check warning on line 117 in src/hover.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Unexpected constant condition

Check warning on line 117 in src/hover.ts

GitHub Actions / Upload vsix package (macos-latest)

Unexpected constant condition
let line = document.lineAt(i).text.trim();
if (!line.startsWith('//')) {
break;
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/extensionManager.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/extensionManager.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
import { SemVer } from 'semver';
import { Logger } from './logger';
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/extension.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/extension.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
import { LanguageClient, LanguageClientOptions, Message, ServerOptions } from 'vscode-languageclient/node';
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/ctags.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/ctags.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
import {exec as execNonPromise} from 'child_process';
import * as util from 'util';
// pattern = parts[2];
type = parts[3];
// override "type" for parameters (See #102)
if (parts.length == 6 && parts[5] === 'parameter:') {

Check warning on line 203 in src/ctags.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Expected '===' and instead saw '=='

Check warning on line 203 in src/ctags.ts

GitHub Actions / Upload vsix package (macos-latest)

Expected '===' and instead saw '=='
type = 'parameter';
}
if (parts.length >= 5) {
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/commands/ModuleInstantiation.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/commands/ModuleInstantiation.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
import * as vscode from 'vscode';
import * as fs from 'fs';
import * as path from 'path';
}
module = modules.filter((tag) => tag.name === moduleName)[0];
}
let scope = module.parentScope != '' ? module.parentScope + '.' + module.name : module.name;

Check warning on line 51 in src/commands/ModuleInstantiation.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Expected '!==' and instead saw '!='

Check warning on line 51 in src/commands/ModuleInstantiation.ts

GitHub Actions / Upload vsix package (macos-latest)

Expected '!==' and instead saw '!='
let ports: Symbol[] = ctags.symbols.filter(
(tag) => tag.type === 'port' && tag.parentType === 'module' && tag.parentScope === scope
);
// SPDX-License-Identifier: MIT

Check failure on line 1 in src/bsvLanguageServer/bsvLanguage.ts

GitHub Actions / Upload vsix package (ubuntu-latest)

Definition for rule '@typescript-eslint/semi' was not found

Check failure on line 1 in src/bsvLanguageServer/bsvLanguage.ts

GitHub Actions / Upload vsix package (macos-latest)

Definition for rule '@typescript-eslint/semi' was not found
type Constructor = new (...a: any[]) => any;
type Merge<TTrait extends Constructor, TTarget extends Constructor> = (new (
...a: ConstructorParameters<TTarget>