Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Click 7.0.0, should restrict dependency to <7.0.0 #82

Closed
antaflos opened this issue Sep 27, 2018 · 1 comment
Closed

Comments

@antaflos
Copy link

It seems click 7.0.0 is quite incompatible with click 6.0.0 so it might be prudent to restrict the dependency on click to >=6.0.0 and <7.0.0.

Otherwise a fresh install of git-up will exhibit problems like this:

Traceback (most recent call last):
  File "/home/vagrant/.local/bin/git-up", line 11, in <module>
    sys.exit(run())
  File "/home/vagrant/.local/lib/python2.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/vagrant/.local/lib/python2.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/vagrant/.local/lib/python2.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/vagrant/.local/lib/python2.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
TypeError: run() takes exactly 4 arguments (3 given)

This is with click 7.0.0 as it is automatically installed by pip when installing git-up. Uninstalling it and installing click 6.0.0 makes git-up work again:

pip uninstall click
pip install click==6.0.0
@msiemens
Copy link
Owner

Thanks for the report! I've released a version which should fix this 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants