Fix windows log hook issues with single/dboule quotes and variable expan... #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dev Conflicts: PyGitUp/gitup.py
|
Looks like I messed up the commits a little, but the end result is correct. |
|
Hey! Thanks for your contribution. Unfortunately it breaks if the user sets the log hook to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
For me this fixes the issues in #11.
I am not sure if this break anything, but it seems like something that's needed on windows.
Modifying single quotes into double quotes prevents windows from interpreting the format as a command.
Modifying single % characters into double (%%) characters prevents windows from expanding variables.
Let me know your thoughts,
Valentijn