Update subprocess handling to avoid hangs / blocking. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bdmartin
commented
Jan 1, 2024
bdmartin
commented
- Update subprocess handling to read both stdout and stderr (to avoid hangs based on blocked pipes).
- Add a unit test to cover that use case.
- This test case would hang before the changes and now it does not.
…angs based on blocked pipes). Add a unit test to cover that use case.
|
@msiemens - Is this something that makes sense to take? |
|
Hey @bdmartin, sorry for the long delay. Seems like you work with bigger repositories than me 🙂 I've merged your PR and will publish a new release in just a minute! |
|
Released in v2.3.0 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.