Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.7 and 3.8, drop 3.4 #99

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Apr 24, 2020

I didn't drop 3.4 from setup.py for now since there was no actual code change, but I don't know about the actual policy for this repo.

@ekohl ekohl mentioned this pull request Apr 24, 2020
@msiemens
Copy link
Owner

Thanks for your PR! For setup.py I usually just list the versions that are used for CI tests. Using PyGitUp with older versions may work but there are no guarantees. If you remove the setup.py line, I'll be happy to merge this 🙂

This environment is no longer available for testing in Azure and is also
EOL.
@ekohl
Copy link
Contributor Author

ekohl commented Apr 26, 2020

That makes sense and I'd probably do the same. I've updated the commits to also update README.rst.

It makes me wonder what you think about dropping Python 2.7.

@msiemens msiemens merged commit fe75d43 into msiemens:master Jun 23, 2020
@msiemens
Copy link
Owner

Thanks @ekohl, this is now merged :)

@ekohl ekohl deleted the 378-support branch June 23, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants