Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc_id handling to Table.Upsert() (#394) #395

Merged
merged 3 commits into from
May 17, 2021

Conversation

benetherington
Copy link
Contributor

Allows upsert to accept a Document with a doc_id attribute.

The cond argument is now optional if a Document (with doc_id) is passed.

@msiemens
Copy link
Owner

Thanks for your work! I've thought about this for a bit and I think this is the best solution of adding doc_id support to upsert considering the differences of doc_id handling between update and insert.

The only thing that's left in my eyes is adding documentation about this in the usage documentation, but I think for now I'll just add a note about this in #371 so I'll remember this when reworking the documentation.

@msiemens msiemens merged commit 6cc942e into msiemens:master May 17, 2021
@msiemens
Copy link
Owner

I'll try to get a release published in the next 1/2 weeks 🙂

@benetherington
Copy link
Contributor Author

I'd love to help with documentation, but it's so readable that I don't want to touch it. Thank you for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants