Refactor Table.delete() to prefer argument doc_ids over cond #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Table.get(cond, doc_id)`, `.contains()`, `.update()`. These methods support both query condition and doc_id(s) as the filter, and `doc_ids` is preferred over `cond`. Refactor `Table.delete()` to make it behave consistent with above methods.
|
Good catch, thanks for contributing a fix! 🙂 |
|
This has now been released in TinyDB v4.5.2 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table.get(cond, doc_id),.contains(),.update(). These methods support both query condition and doc_id(s) as the filter.When query
condanddoc_idare passed as params at the same,doc_idis preferred overcondand onlydoc_idis used.Refactor
Table.delete()to make it behave consistent with above methods.