Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Python 3.12 and add trove classifier #548

Merged

Conversation

edgarrmondragon
Copy link
Contributor

No description provided.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/python3.12 branch from 5a8ccd0 to 95cbb33 Compare December 2, 2023 01:46
@edgarrmondragon
Copy link
Contributor Author

Tests are passing over on my fork, so let me know if there's interest in this.

Copy link
Contributor

@ruancomelli ruancomelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msiemens these changes look correct. Can we get it merged? I'm also interested in having support for Python 3.12 😀

@edgarrmondragon
Copy link
Contributor Author

@msiemens these changes look correct. Can we get it merged? I'm also interested in having support for Python 3.12 😀

@ruancomelli FWIW Python 3.12 is already supported, this just declares support via the PyPI trove classifier and adds 3.12 to the test matrix.

@edgarrmondragon edgarrmondragon changed the title Support Python 3.12 Test with Python 3.12 and add trove classifier Jan 12, 2024
@ruancomelli
Copy link
Contributor

@ruancomelli FWIW Python 3.12 is already supported, this just declares support via the PyPI trove classifier and adds 3.12 to the test matrix.

Hey @edgarrmondragon! Yes, I'm aware of that, but thanks for pointing it out!

I guess I meant "official support for Python 3.12", which is exactly what you did - without official support (including adding 3.12 to the test matrix), it would be unsafe to update tinydb in Python 3.12 projects since Python-3.12-incompatible changes could be introduced at any time... with official support and testing, this won't happen.

Additionally, some tools don't really like installing dependencies if official support for the project's Python version is not declared on PyPI, which makes this PR twice as valuable :)

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/python3.12 branch from 95cbb33 to 88a5ca1 Compare January 19, 2024 01:36
@edgarrmondragon
Copy link
Contributor Author

Ping @msiemens :)

@msiemens msiemens merged commit f3caf6a into msiemens:master Oct 5, 2024
@msiemens
Copy link
Owner

msiemens commented Oct 5, 2024

Thanks everyone!

@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/python3.12 branch October 6, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants