more rules to disallow flaky locators like allTextContents

[eins78]

I would like to have more rules to disallow flaky locators like .allTextContents().

As far as I can see there is only a rule for .count(), but the docs have warnings for more "flaky text assertions. See Warnings that mention "avoid flakiness" on the docs: https://playwright.dev/docs/api/class-locator#locator-all-text-contents

[MSroczynski3]

Hi @eins78 👋

I believe that this rule is what you might be looking for! It bundles many flaky assertions and suggest web first assertions.

Do you think that the rule should be extended to include more flaky assertions?

[mskelton]

Yeah, prefer-web-first-assertions is the rule, but .allTextContents isn't currently supported.

[MSroczynski3]

I will add it 👍

[MSroczynski3]

Done here: #382.

As a future improvement should we make the fixer suggest the useInnerText option with the expect(locator).toHaveText() when replacing both allInnerTexts() and innerText() as per suggestions in the documentation?

[mskelton]

@MSroczynski3 Maybe? My only hesitation is complexity, but if we can do it without a lot of added complexity, then sure.

[MSroczynski3]

@mskelton Yeah there are couple of quirks there. This is what I came up with. Adds a little bit of complexity but does not look that bad. WDYT?