Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clicking today in range mode the whole range should be set #162

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

whishkid
Copy link
Contributor

@whishkid whishkid commented Feb 20, 2024

#161

I modified clicking to day, to mimick setting start date and time and end date and time if in range mode

This one might need some discussion, not sure if you will agree with the proposed solution regarding time range, but it seems like what you want to select in range mode when you click on today.

@whishkid
Copy link
Contributor Author

I noticed some mentions about seconds and milliseconds not being parsed.
If you prefer, I can set the end date to tomorrow start of day, which is pretty much the same things as today 23:59:59:999

@mskocik
Copy link
Owner

mskocik commented Feb 20, 2024

Seconds and miliseconds are not important, I am setting them to 0 all the time.

I would say the today button in range mode has meaning just for date not datetime mode. I will check the code and think about it more later.

@mskocik
Copy link
Owner

mskocik commented Feb 21, 2024

I tried to think about it and I have nothing to add here. As I wrote before, today button doesn't make sense in datetime mode. But if you think this should be the correct behaviour, I am fine with it.

@whishkid
Copy link
Contributor Author

I tried to think about it and I have nothing to add here. As I wrote before, today button doesn't make sense in datetime mode. But if you think this should be the correct behaviour, I am fine with it.

Im definitely fine with it for now... I cannot merge so that is up to you :)

@whishkid
Copy link
Contributor Author

Another querstion... when everything is merged is it automatically deployed to npm or is that something you do manually in a release schedule or something?

@mskocik mskocik merged commit 094d3db into mskocik:main Feb 21, 2024
@mskocik
Copy link
Owner

mskocik commented Feb 21, 2024

I do releases manually. And I am going to do it right now. Was waiting for your reply, if you are fine with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using date ranges and clicking on the Today button the range should be set with from and to
2 participants