Add breeds-get Lambda Function #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repository is not available. This could alternatively be made public, but since none of the other packages reference the artifact repository, this seems accidental.
…peScript 4, but version 3.6.4 is currently being used. microsoft/TypeScript#36775
…the API and transforms the response into flattened list of sub-breed and breeds
funador
reviewed
Mar 1, 2021
funador
reviewed
Mar 1, 2021
funador
reviewed
Mar 1, 2021
funador
reviewed
Mar 1, 2021
Collaborator
funador
left a comment
funador
left a comment
There was a problem hiding this comment.
Hi Mark,
Thanks for taking the time to complete the challenge. Some really solid work here. I left a couple of comments in the PR. In addition, I noticed a couple of other issues:
- when I run
yarn lintthere is an error - Can we use the same directory structure for
randomas we did forbreedsthis will help maintain consistency
I really appreciate all your efforts so far. Please let me know if you have any questions about anything. Looking forward to seeing what you come up with.
Cheers
funador
reviewed
Mar 1, 2021
funador
reviewed
Mar 1, 2021
…ONNRESET' error to simulate a timeout
…a designated amount of time and add tests for aborted api calls
Owner
Author
|
@funador I think I've addressed all of the code comments. Let me know if you see any others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new lambda function to retrieve the list of dog breeds from the API and transforms the response (an object with breeds as keys and sub-breeds as the values) to an array of strings