Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version tag 0.10.0 is outside msm's repository, and does not include updates to changelog merged in PR #416 #436

Closed
Next-Door-Tech opened this issue Nov 25, 2021 · 2 comments

Comments

@Next-Door-Tech
Copy link
Contributor

The Issue

Tag 0.10.0 currently points to commit 2864209, which is actually not to a member of the proper msmhq/msm repository (I'm actually not 100% sure where it does belong). The corresponding commit actually on the tree is 6c1d8c7.

Additionally, Pull Request #416 Fix change log entry for version 0.10.0 was merged downstream of Tag 0.10.0. This means that the commit with the correct changelog for 0.10.0 is actually several commits ahead of where the tag points, and the tag currently does not have the correct changelog. The commit with the correct changelog for 0.10.0 is 5c28b6f.

How to Resolve

The existing Tag 0.10.0 (pointing to 2864209) first needs to be deleted, and then a new Tag 0.10.0 pointing to 6c1d8c7 needs to be created in its place.

Unfortunately, I can't create a pull request for deleting or creating a tag; this needs to be done directly by one of the msm repository maintainers.

As a side note, if you merge Pull Request #432 before doing this, you also fix issue #435 at the same time.

@antoinelafontaine
Copy link

It would be nice to see those pull request accepted...

@endofcake
Copy link
Contributor

endofcake commented Apr 29, 2023

Tag 0.10.0 moved to now point to 5c28b6f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants