-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the git-release GitHub Action workflow constantly creating errors #432
Conversation
Option was deprecated in git-release v4.0.0. No replacement is needed b/c msm's version tags do not have a static prefix before the version number. (i.e. tag name is "0.9.10", not "version-0.9.10")
Done to prevent future issues due to major updates to git-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disregard this comment, I can't delete it for some reason.
OK, sorry for creating four new issues after submitting this pull request. Not really sure what issue tracking demon took hold of me there. Here's the TL;DR for those issues. You can essentially ignore #433 and #434 - they are the problems I mention fixing in this PR description. Simply merging this PR will resolve these two directly - not sure why I decided they needed their own issues after submitting it. #435 and #436 are the important two which go a bit beyond this PR. You might actually want to take the time to read those in full for more details. #435 #436 Unfortunately, I can't create a pull request to delete or create a tag, so #436 requires manual intervention from a repo maintainer. That said, re-creating the 0.10.0 tag with |
Thanks for looking into this @Next-Door-Tech. Sorry it took so long, the last few years were full-on. |
This PR fixes the
git-release
GitHub Action so that it does not create a failed workflow error every time any commit is pushed tomaster
. Also removes unneeded environment variable which was deprecated in the v4.0.0 update togit-release
.The previous syntax was set to trigger
git-release
every time a version tag was created or updated, AND when any commit was pushed tomaster
. I assume the intended behavior was to trigger the workflow when a tag on themaster
branch is created or updated.The new syntax will trigger when a tag is updated or created anywhere in the repository, but will still only trigger for tags with names of exactly 3 numbers separated by periods. (i.e. will match
0.9.10
or1.2.3
, will not matchtagname
,version-0.9.10
, or0.9