Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the git-release GitHub Action workflow constantly creating errors #432

Merged
merged 3 commits into from
Apr 29, 2023

Conversation

Next-Door-Tech
Copy link
Contributor

This PR fixes the git-release GitHub Action so that it does not create a failed workflow error every time any commit is pushed to master. Also removes unneeded environment variable which was deprecated in the v4.0.0 update to git-release.

The previous syntax was set to trigger git-release every time a version tag was created or updated, AND when any commit was pushed to master. I assume the intended behavior was to trigger the workflow when a tag on the master branch is created or updated.

The new syntax will trigger when a tag is updated or created anywhere in the repository, but will still only trigger for tags with names of exactly 3 numbers separated by periods. (i.e. will match 0.9.10 or 1.2.3, will not match tagname, version-0.9.10, or 0.9

Option was deprecated in git-release v4.0.0. No replacement is needed b/c msm's version tags do not have a static prefix before the version number. (i.e. tag name is "0.9.10", not "version-0.9.10")
Done to prevent future issues due to major updates to git-release
Copy link
Contributor Author

@Next-Door-Tech Next-Door-Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard this comment, I can't delete it for some reason.

@Next-Door-Tech
Copy link
Contributor Author

OK, sorry for creating four new issues after submitting this pull request. Not really sure what issue tracking demon took hold of me there. Here's the TL;DR for those issues.

You can essentially ignore #433 and #434 - they are the problems I mention fixing in this PR description. Simply merging this PR will resolve these two directly - not sure why I decided they needed their own issues after submitting it.


#435 and #436 are the important two which go a bit beyond this PR. You might actually want to take the time to read those in full for more details.

#435 Release for 0.10.0 still missing - continuation of #412 basically says that when you first implemented git-release due to a missing release for 0.10.0, you fixed the issue for tags created in the future but forgot to manually add the release for 0.10.0. That said, don't manually add the release for 0.10.0! Fixing issue #436 after merging this PR will fix this issue on its own.

#436 Version tag 0.10.0 is outside msm's repository, and does not include updates to changelog merged in PR #416 is pretty self explanatory. Tag 0.10.0 currently points to a commit that isn't on any branch of the msmhq/msm repository, and the tag doesn't include its own changelog. In short, you need to delete the current 0.10.0 tag and create a new tag with the same name pointing to the correct commit. Go see the actual issue for more details as well as a link to the commit that needs to be tagged.

Unfortunately, I can't create a pull request to delete or create a tag, so #436 requires manual intervention from a repo maintainer. That said, re-creating the 0.10.0 tag with git-release functioning again from this PR will automatically create a 0.10.0 release - that solves #435 and acts as a test of this PR to boot.

@endofcake endofcake merged commit 711b15a into msmhq:master Apr 29, 2023
@endofcake
Copy link
Contributor

Thanks for looking into this @Next-Door-Tech. Sorry it took so long, the last few years were full-on.
It looks like I'm the only maintainer left, and I lack admin right to add more maintainers, so I'm not sure how to improve the situation.

@Next-Door-Tech Next-Door-Tech deleted the git-release branch July 17, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants