Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deserialization for packed structures #85

Merged
merged 5 commits into from
Jul 16, 2016
Merged

Add deserialization for packed structures #85

merged 5 commits into from
Jul 16, 2016

Conversation

msoucy
Copy link
Owner

@msoucy msoucy commented Jul 9, 2016

Fixes #77

Not ready to merge yet, still needs to look at the actual wire type instead of looking for isPacked.

@coveralls
Copy link

coveralls commented Jul 9, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 76.051% when pulling e6800f9 on issue-77 into e1decc8 on master.

@msoucy msoucy merged commit 5475157 into master Jul 16, 2016
@msoucy msoucy deleted the issue-77 branch July 16, 2016 17:26
@WebDrake
Copy link
Contributor

WebDrake commented Aug 9, 2016

Any chance of a point release with this fix included?

@msoucy
Copy link
Owner Author

msoucy commented Aug 12, 2016

It's not quite correct (see #89) but v2.0.2 has it

@WebDrake
Copy link
Contributor

Cool, thanks. I might just wait for v2.0.3 though, since AFAICS you fixed #89 in a more recent patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msoucy @coveralls @WebDrake