Skip to content

Commit

Permalink
ACPI/APEI: Clear GHES block_status before panic()
Browse files Browse the repository at this point in the history
[ Upstream commit 98cff8b ]

In __ghes_panic() clear the block status in the APEI generic
error status block for that generic hardware error source before
calling panic() to prevent a second panic() in the crash kernel
for exactly the same fatal error.

Otherwise ghes_probe(), running in the crash kernel, would see
an unhandled error in the APEI generic error status block and
panic again, thereby precluding any crash dump.

Signed-off-by: Lenny Szubowicz <lszubowi@redhat.com>
Signed-off-by: David Arcari <darcari@redhat.com>
Tested-by: Tyler Baicar <baicar.tyler@gmail.com>
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
LennySzubowicz authored and gregkh committed Feb 12, 2019
1 parent 71d357a commit 74a65f5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/acpi/apei/ghes.c
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,8 @@ static void __ghes_panic(struct ghes *ghes)
{
__ghes_print_estatus(KERN_EMERG, ghes->generic, ghes->estatus);

ghes_clear_estatus(ghes);

/* reboot to log the error! */
if (!panic_timeout)
panic_timeout = ghes_panic_timeout;
Expand Down

0 comments on commit 74a65f5

Please sign in to comment.