Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (deployment): [rgs] follow the region resource recommendations #99

Merged

Conversation

ferantivero
Copy link
Contributor

@ferantivero ferantivero commented Sep 11, 2024

  • modify resource group creation to make the location part of the resource group's name
  • modify network and cluster biceps to convert the location param to a variable defaulting to the rg location
  • modify steps to use new naming convention and remove location argument

image

@ferantivero ferantivero marked this pull request as ready for review September 14, 2024 02:08
Copy link

@johndowns johndowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've proposed a few small edits.

Question: do you think it's necessary to include the region in the resource group names? I'm thinking it might simplify things if we omit it, because all of the resource groups are in one region anyway, and it would reduce the number of places to change if you want to deploy to a region other than Central US. Any thoughts?

networking/hub-region.v1.bicep Outdated Show resolved Hide resolved
networking/hub-region.v2.bicep Outdated Show resolved Hide resolved
networking/spoke-BU0001A0005-00.bicep Outdated Show resolved Hide resolved
networking/spoke-BU0001A0005-01.bicep Outdated Show resolved Hide resolved
@ferantivero
Copy link
Contributor Author

I've proposed a few small edits.

Question: do you think it's necessary to include the region in the resource group names? I'm thinking it might simplify things if we omit it, because all of the resource groups are in one region anyway, and it would reduce the number of places to change if you want to deploy to a region other than Central US. Any thoughts?

Open to remove the location from the rg name if requested. Thing is same task had been carried on in many other repos already and they are following this convention.

While I would agree this simplify our docs deployment steps, most probably (and the recommendation) is to include this information as part of the naming.

Open to go either way.

@johndowns
Copy link

OK, fair enough - if we're doing it consistently elsewhere then I'm happy to go with the standard approach.

@ferantivero
Copy link
Contributor Author

#sign-off

@johndowns
Copy link

@ferantivero Would you be able to please resolve the conflict and sign off again when you're happy?

@ferantivero ferantivero force-pushed the feature/217264_follow-rg-recommendations branch from 760b26f to 4f15e9d Compare November 4, 2024 13:24
@ferantivero
Copy link
Contributor Author

@ferantivero Would you be able to please resolve the conflict and sign off again when you're happy?

this is now resolved @johndowns

@johndowns johndowns merged commit 6599b9e into mspnp:main Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants