Update 07-workload-prerequisites.md with warning about PKCS formats #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding additional warning regarding accepted private key formats for Azure Key Vault.
|
Wow, good catch. @magrande, can you confirm that you missed that file when doing the Traefik update? @scaswell-hirez, you'll need to sign the CLA if you would like this contribution committed. |
|
@scaswell-hirez -- can you rebase your branch? This change that you proposed for the Traefik version has already been made. The other comment though didn't. Maybe you can rebase and reopen the PR with the updated title/description to match. Thanks. |
Merge mspnp into hirez fork
|
Thanks for the rebase. If you want to update the title and description now to match the contents of this PR, that would be helpful. |
scaswell-hirez
changed the title
ckittel
requested changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Key Vault will reject PEM files that contain private keys that are not in PKCS8 format.