Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch (network topology): [appgw] right size appgw snet #304

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

ferantivero
Copy link
Contributor

closes: #293, #577305

WHY

it seems we are running a bit small based on the current recommendation, and we should consider right-sizing the appgw subnet based on this change and updating our topology details doc for this.

WHAT Changed?

  • docs
  • right size app gw snet from /28 to /24
  • change app gw cidr
  • whitelisted the new address prefix from in-cluster ingress

HOW to Test?

we deploy the cluster and the everything works exactly as before. But the app gw subnet now has 251 seats available for app gw instances.

Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Can you also update the draw.io image network-topology.drawio.

image

@ferantivero ferantivero force-pushed the feature/577305_right-size-appgw-snet branch from d9e2df8 to 1c60c68 Compare April 22, 2022 12:35
@ckittel
Copy link
Member

ckittel commented Apr 22, 2022

Thanks. Merging.

@ckittel ckittel merged commit 7b5f9ac into main Apr 22, 2022
@ckittel ckittel deleted the feature/577305_right-size-appgw-snet branch April 22, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App gateway subnet too small?
2 participants