This repository has been archived by the owner on Feb 17, 2023. It is now read-only.
Detect updated UA for Googlebot #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssola
suggested changes
Nov 30, 2017
operating_systems.go
Outdated
| @@ -89,6 +89,9 @@ func webkit(p *UserAgent, comment []string) { | |||
| if len(comment) > 3 { | |||
| p.localization = comment[3] | |||
| } | |||
| if len(comment) == 3 { | |||
There was a problem hiding this comment.
Prefer to use an else if instead 😉
mssola
approved these changes
Nov 30, 2017
|
Thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google announced they changed UA for Googlebot.
The most significant change is that the new one has
Androidinstead ofiPhone. This patch adds the detection by calling thep.googleBot()method accordingly.In addition to that, this PR includes diff to use subtest feature. With this,
go test -vshows test titles neatly and makes easy to find failed ones.updated
hmm... Test has failed due to subtest feature. But the old Go's (<1.7) may be removed, I think.