This repository has been archived by the owner on Feb 17, 2023. It is now read-only.
Added Detection of Chromium Edge on Windows #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved bingbot and googlebot detection to beginning of AppleWebKit section to avoid false-positive for Chromium Edge from 'Edg' in bingbot. Added case 'Edg' to account for Chromium Edge on Windows. Added test case for Chromium Edge on Windows. Updated Changelong. Signed-off-by: Dan Hammer <daniel.m.hammer@gmail.com>
mssola
approved these changes
Aug 25, 2020
|
Thanks! 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved bingbot and googlebot detection to beginning of AppleWebKit section to avoid false-positive for Chromium Edge from 'Edg' in bingbot.
Added case 'Edg' to account for Chromium Edge on Windows.
Added test case for Chromium Edge on Windows.
Updated Changelong.
Signed-off-by: Dan Hammer daniel.m.hammer@gmail.com
Fixes #69
Provide a general description of the changes in your pull request. If this pull request fixes a known issue, please tag it as well (e.g.:
Fixes #1).Before submitting a PR make sure the following things have been done (and denote this by checking the relevant checkboxes):
make ci).Thanks for contributing to user_agent!