WIP: Add options for skipping downloading tools targeting ARM/ARM64, and for skipping ATL and DIA SDK #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mstorsjo much-needed feature. Most of the time, we don't need ARM and ARM64 architecture support and this causes the huge size of the container |
hacksysteam
added a commit
to hacksysteam/msvc-wine
that referenced
this pull request
Sep 24, 2024
* Added colors to output messages to highlight important information. * Switched from multiprocessing to ThreadPoolExecutor for downloads. * Added tree like structure to --print-deps, --print-reverse-deps and --print-selection. * Merged mstorsjo#140 * Merged mstorsjo#144
This was referenced Sep 24, 2024
…and for skipping ATL and DIA SDK
mstorsjo
force-pushed
the
download-options
branch
from
0554016 to
5c06245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes on top of #143.
This works, but is quite primitive. If someone wants to pick this PR up and develop it further, that would be very much appreciated! (CC @huangqinjin)
I wanted to make it possible to skip downloading architectures, and/or extra libraries that you don't need. (Although ATL seems very small so it doesn't make much of a difference in any way whether we include it or not.)
I tried to make this general enough that you'd be able to say e.g. that you only want to target e.g. x86 and x64, and thus not adding the extra e.g.
*.ARM64package selections. But if one only wants a compiler to target ARM but not x86/x64 at all, I think we'd need to manually select some more packages, at least for the latest version (when not selecting a version with--msvc-version).As an extra, if one has skipped installing ARM/ARM64 files, we could also remove a lot of large libraries under WinSDK, but I didn't implement that yet.