Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer #162

Closed
jmbrunskill opened this issue Oct 2, 2023 · 14 comments · Fixed by #275
Closed

Windows installer #162

jmbrunskill opened this issue Oct 2, 2023 · 14 comments · Fixed by #275
Assignees
Labels
enhancement New feature or request

Comments

@jmbrunskill
Copy link
Collaborator

Is your feature request related to a problem? Please describe

A windows installer similar to OMS

Describe the solution you'd like

Installer should setup things like environment variables needed to correctly connect from rust to a postgres db
It should also install any default templates required

Describe alternatives you've considered

Additional context

@jmbrunskill jmbrunskill added the enhancement New feature or request label Oct 2, 2023
@jmbrunskill jmbrunskill self-assigned this Oct 2, 2023
@jmbrunskill
Copy link
Collaborator Author

jmbrunskill commented Oct 30, 2023

@raviSussol do you have time and experience to look at this?

I think we want it to be basically the same as the installer for open-mSupply.

Will need to do the things like setting up the path to libpq.dll similar to what open-mSupply's installer does.

I'm thinking we should use the path C:\Program Files\notify\notify_service.exe (that's what I've been using so far anyway)

@raviSussol
Copy link
Collaborator

@jmbrunskill Yes, I'll have a look at this one.

@raviSussol raviSussol assigned raviSussol and unassigned jmbrunskill Oct 30, 2023
@jmbrunskill
Copy link
Collaborator Author

Fantastic thanks @raviSussol !

@raviSussol
Copy link
Collaborator

raviSussol commented Nov 2, 2023

@jmbrunskill Do we have any particular icon image for notify app? Would be good to show in the notify_server.exe and in the installation window (like the msupply or openmsupply apps have). If not then can use the same image as open msupply has.

@mark-prins
Copy link
Contributor

Not yet - I've asked Anisha about creating one 😉

@jmbrunskill
Copy link
Collaborator Author

Would be great to have one!

@jmbrunskill
Copy link
Collaborator Author

@raviSussol How are you getting on with this?
Do you think you'll have time to finish this week?

@raviSussol
Copy link
Collaborator

@jmbrunskill I'll try to finish this week. Meanwhile, have we got a notify app icon now?

@jmbrunskill
Copy link
Collaborator Author

Thanks @raviSussol let me know if you have other questions!
I don't think we'll get a logo any time soon, so I'd say lets go ahead with the current mSupply one you had started with.

@mark-prins
Copy link
Contributor

@raviSussol here's a logo that you can use for now - I've just made one while we wait for Anisha to get time to work on it.

notify-logo.ico.zip
notify-logo

@raviSussol
Copy link
Collaborator

Thanks @mark-prins hehe... nice logic!! But it works!

@raviSussol
Copy link
Collaborator

@mark-prins Can you also generate the same picture in the png format with below shape and size?

  1. side_banner
  2. top_banner

@mark-prins
Copy link
Contributor

Sure 😉
side_banner
top_banner

@raviSussol
Copy link
Collaborator

Nice! Thanks @mark-prins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants