-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
162 windows installer setup #275
Conversation
β¦s' into 162-windows-installer-setup
Bundle size differenceComparing this PR to
|
Update license to reflect opensource
Fix formatting issues in license file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
However, It looks like the templates directory is missing?
Can you add this, and make sure it gets updated with an upgrade?
This is needed for the coldchain alerts, they use these templates.
Is it possible to get the build number from the git tag here?
I think we should probably use Notify
instead of Notify Service
(it's already a service)
Similar for the install location, I think we should probably use C:\Program Files\notify
?
That does potentially create a problem for existing installs, but we can be across that when we update from the manual install to this installer...
Thanks for reviewing @jmbrunskill. I've updated a pr - addressing all your mentioned issues above. Could you please review again? The new installer: https://jenkins.msupply.org:8443/job/notifyMain%20-%20Installers/ for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast work Ravi!
Working great!
Closes #162
π©π»βπ» What does this PR do?
Added a windows installer build script for the notify app.
π§ͺ How has/should this change been tested?
Download installer from here and test it.
Or, create a new tag (starts with vxx.xx.xx) and then push to the origin. Jenkins will automatically fire the windows installer build job in the https://jenkins.msupply.org:8443/job/notifyMain/
π Any notes for the reviewer?
π Documentation
No user facing changes
or