5646 item direction table #5752
Conversation
github-actions
bot
added
Team Piwakawaka
Chris-Petty
requested review from
a team,
CarlosNZ and
jmbrunskill
and removed request for
a team
|
|
||
| #[derive(Clone, Default, PartialEq, Debug)] | ||
| pub struct ItemDirectionFilter { | ||
| pub id: Option<EqualFilter<String>>, |
There was a problem hiding this comment.
I think we're going to want a filter on item_id, could be done later though, so I'm happy if it's not in this PR.
| id TEXT NOT NULL PRIMARY KEY, | ||
| item_link_id TEXT NOT NULL REFERENCES item_link(id), | ||
| directions TEXT NOT NULL, | ||
| priority BIGINT NOT NULL |
There was a problem hiding this comment.
I would have thought INTEGER would be ok, I guess big int is fine too.
There was a problem hiding this comment.
I had integer and diesel postgres was throwing a wobbly on i64 not receiving enough bytes
|
|
||
| let result = ItemDirectionRow { | ||
| id: data.ID, | ||
| item_link_id: data.item_ID, |
There was a problem hiding this comment.
Is it safe to assume an item_id is also an item_link_id? Feels like we might need to look up the item_id based on this, but then I always get confused with *_link tables...
There was a problem hiding this comment.
The item link tables are populated with item.id == item_link.id == item.item_link_id so it should be fine I think!
| Clone, Insertable, Queryable, Debug, PartialEq, AsChangeset, Eq, Serialize, Deserialize, | ||
| )] | ||
| #[diesel(table_name = item_direction)] | ||
| #[diesel(treat_none_as_null = true)] |
There was a problem hiding this comment.
This line is a little bit pointless with no nullable columns :)
Fixes #5646
👩🏻💻 What does this PR do?
Adds migration, repo and sync logic for the
item directiontable