-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6295 add crawl function for generating reports #6347
6295 add crawl function for generating reports #6347
Conversation
Also move super long function into utils file
server/cli/src/report_utils.rs
Outdated
} | ||
(Some(arguments_path), Some(arguments_ui_path)) => Some( | ||
schema_from_row(FormSchemaRow { | ||
id: argument_schema_id.unwrap_or(format!("for_report_{}", id)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think format!("for_report_{}") is enough for all cases. Getting some id from local database doesn't make sense to me, reports are not database specific. Also I don't think that report making should rely on any database operations, please remove con. (It's not a new change in this PR, i understand, but would be great to get rid of it for now )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks, although I haven't tested.
There is one change please, sorry it's not related to your new chagnes, but I would like it cleared up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank !
Fixes #6295
π©π»βπ» What does this PR do?
π Any notes for the reviewer?
I've also updated error handling to make diagnosing errors with report development more easeful.
I was a little unsure about when to throw an error vs when to continue with other reports which might be working fine.
π§ͺ Testing
(Testing for devs - the report build cli is not accessible in testers environment)
π Documentation