Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6175 prescription price columns #6356

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

zachariah-at-msupply
Copy link
Contributor

Fixes #6175

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Adds cost and sell price columns to the prescription view.

image

I removed some of the other columns from the screenshot to highlight the new ones that are available. All the original columns are still available but the 'line total' column is now 'sell price'.

πŸ’Œ Any notes for the reviewer?

Sup, how's it going?

πŸ§ͺ Testing

  • Make sure you have multiple batches of the same medecine, with different sell and cost prices.
  • Create a prescription and sdd both of those different batches of the same medecine to it.
  • Go to the prescription's detail view, and check that the sell price column = sell price of one batch * quantity of packs of that batch being dispensed + sell price of the other batch * quantity of packs of that other batch being dispensed, and similar with the cost column.

πŸ“ƒ Documentation

  • [ x ] Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • [ x ] These areas should be updated or checked: New sell and cost price columns in the Prescriptions detail view.

@github-actions github-actions bot added this to the v2.6.0 milestone Jan 30, 2025
@github-actions github-actions bot added Team Piwakawaka James, Carl, John, Zachariah feature: dispensing labels Jan 30, 2025
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.26 MB 5.26 MB 221 B (0.00%)

{
label: 'label.line-total',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing the line total?

Copy link
Contributor Author

@zachariah-at-msupply zachariah-at-msupply Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'line total' column is now named 'sell price'. The issue asks for 'sell price', and it turns out the line total column has the same content as sell price. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachariah-at-msupply just had a chat with Mark Prins, can we change this back to unit-total for now.
We can update the french version for CIV to be what they want it to be.

Also, can we add a new translation for label.total-sell-price as normally sell price is the unit price (not the total, so would be nice to distinguish.

I'm also a bit confused by the diff, I think maybe due to the ordering, would you mind putting the lineTotal first, then total cost price at the end of the list. Most users won't be using costPrice so I think it's good to have this one last.

@jmbrunskill jmbrunskill self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dispensing Team Piwakawaka James, Carl, John, Zachariah
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispensing: Cost price in Prescription Detail View
3 participants