-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6289 Insurance fields on Invoice #6503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarlosNZ this fixes the sync tests.
6289-insurance-fields-on-invoice...6289-invoice-sync-fixes
Will do a proper review later on...
ALTER TABLE invoice | ||
ADD COLUMN insurance_discount_amount {DOUBLE}; | ||
ALTER TABLE invoice | ||
ADD COLUMN insurance_discount_rate {DOUBLE}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's worth changing but in name_insurance_join I called this discount_percentage
I like to explicitly say it's a percentage vs rate which could be a ratio or 0.1 for 10% for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agreed: e24245c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go once my branch is merged
Thanks @jmbrunskill -- think it's all good now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Carl, looks good to me!
Fixes #6289
Just making a draft PR real quick so @jmbrunskill can have a look. Will flesh out the details here shortly.
π©π»βπ» What does this PR do?
name_insurance_join_id
insurance_discount_amount
insurance_discount_percentage
π§ͺ Testing
(Will write more thorough tests for the UI part of this )