-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6531 update standard report filter dropdown translation keys #6538
base: v2.6.0-RC
Are you sure you want to change the base?
6531 update standard report filter dropdown translation keys #6538
Conversation
Bundle size differenceComparing this PR to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you Noel,
A small change required to ensure version compatibility for 2.3, but otherwise great. Thank you :)
["item.name", "T#report.item-name"], | ||
["batch", "T#label.batch"], | ||
["item.code", "T#label.code"], | ||
["expiryDate", "T#report.expiry-date"], | ||
["location.code", "T#label.location"], | ||
["item.unitName", "T#label.unit"], | ||
["packSize", "T#label.pack-size"], | ||
["totalNumberOfPacks", "T#label.num-packs-total"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the functionality to translate the json schema with the "T#" identifier was added as part of 2.5 release, so these changes are not compatible with OMS version 2.3.
So in this case, you'll need to make a new version of the stock-detail report as version 2.5 to include these changes.
This is to prevent a site on version 2.3 trying to render this report and showing up the raw translation keys.
Technically speaking a remote site on version 2.3 shouldn't receive this updated report because version 2.3 doesn't yet have syncing from OMS central server added, but it is good practice to ensure that we keep versioning consistent and don't try to render anything incompatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fergie-nz thanks for pointing that out! Updated here: 720a52b
Do I need to revert changes to 2.3 version or can I leave as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please you would need to revert changes in the 2.3 commit.
However you could do something like rename this version to 'latest', then copy and paste the 2.3 version from the develop branch (so you don't need to manually revert anything, just copy in the previous version).
The dif in your PR should show that nothing has changed in the 2.3 directory.
Fixes #6531
π©π»βπ» What does this PR do?
Add translation keys for report sort by dropdown options.
Changes needed as all dropdown options were showing in english irrespective of user selected language.
π Any notes for the reviewer?
Note item usage report styling is a known issue.
π§ͺ Testing
π Documentation
1.
2.