Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6533 pagination for period #6554

Merged
merged 6 commits into from
Feb 20, 2025
Merged

6533 pagination for period #6554

merged 6 commits into from
Feb 20, 2025

Conversation

roxy-dao
Copy link
Contributor

Fixes #6533

👩🏻‍💻 What does this PR do?

Defaults shown periods to 15 and only show past periods.

🧪 Testing

  • Have lots of periods over 30?
  • Set up CIV stocktake report
  • Go to report and click on stocktake report
  • Only limited of periods shown until you keep scrolling

📃 Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the v2.6.0 milestone Feb 18, 2025
@github-actions github-actions bot added the Team Ruru 🦉 Roxy, Ferg, Noel label Feb 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.95 MB 5.95 MB 716 B (0.01%)

@fergie-nz fergie-nz self-assigned this Feb 20, 2025
fergie-nz
fergie-nz requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@fergie-nz fergie-nz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome - some issue showing the current period when not mapped exactly to months

@roxy-dao roxy-dao changed the base branch from develop to v2.6.0-RC February 20, 2025 02:27
@roxy-dao roxy-dao modified the milestones: v2.6.0, v2.6.0-RC1 Feb 20, 2025
@roxy-dao roxy-dao requested a review from fergie-nz February 20, 2025 02:38
fergie-nz
fergie-nz approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@fergie-nz fergie-nz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice LGTM! 🎸

@roxy-dao roxy-dao merged commit 9654b53 into v2.6.0-RC Feb 20, 2025
4 checks passed
@roxy-dao roxy-dao deleted the 6533-Pagination-for-period branch February 20, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergie-nz fergie-nz fergie-nz approved these changes

Assignees

@fergie-nz fergie-nz

Labels
Team Ruru 🦉 Roxy, Ferg, Noel
Projects
None yet
Milestone
v2.6.0-RC1
Development

Successfully merging this pull request may close these issues.

Pagination for period
2 participants
@roxy-dao @fergie-nz