fix: resolve relative fetch urls against location #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kettanaito
commented
Jan 25, 2024
kettanaito
commented
- Fixes Node interceptors don't resolve relative URLs when "location" is present msw#1625
kettanaito
commented
Jan 25, 2024
| * for native `fetch` in JSDOM. | ||
| * @see https://github.com/mswjs/msw/issues/1625 | ||
| */ | ||
| const resolvedInput = |
There was a problem hiding this comment.
My only concern is that this will force the relative request URL resolution even for environments where making a request to a relative URL is allowed (i.e. the browser).
4 tasks
kettanaito
commented
Jan 25, 2024
| * can be parsed into a `URL` instance. | ||
| * A substitute for `URL.canParse()` for Node.js 18. | ||
| */ | ||
| export function canParseUrl(url: string): boolean { |
There was a problem hiding this comment.
We should replace this with URL.canParse once Node.js 20 is the minimal version to use with MSW.
Released: v0.25.15 🎉This has been released in v0.25.15! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.