feat(ClientRequest): await response listeners before emitting the "end" response event #591
Conversation
| @@ -419,7 +434,7 @@ export class NodeClientRequest extends ClientRequest { | |||
| const firstClone = cloneIncomingMessage(response) | |||
| const secondClone = cloneIncomingMessage(response) | |||
|
|
|||
| this.emit('response-internal', secondClone) | |||
| this.emit('response-internal', secondClone, firstClone) | |||
There was a problem hiding this comment.
We need to expose the original IncomingMessage of the original response if we wish to delay its end event emission. This modifies the listener call signature of the response-internal event.
| @@ -643,4 +658,23 @@ export class NodeClientRequest extends ClientRequest { | |||
| // @ts-ignore "agent" is a private property. | |||
| this.agent?.destroy?.() | |||
| } | |||
|
|
|||
| private deferResponseEndUntil( | |||
There was a problem hiding this comment.
Maybe premature but I'm creating a private method to help us reuse the same deferring logic for both mocked and original responses (the target IncomingMessage is different in case of both).
There was a problem hiding this comment.
I will likely repurpose this for the Socket interceptor. It would have its own implementation of awaiting the response listeners.
| @@ -69,6 +69,7 @@ beforeAll(async () => { | |||
| }) | |||
|
|
|||
| afterEach(() => { | |||
| interceptor.removeAllListeners('response') | |||
There was a problem hiding this comment.
Incredibly flaky test poorly written. Shame on me.
I'm resetting the response listener because they apparently leak between the tests through the shared interceptor instance.
I've been scoping request/response listeners within individual tests for some time to prevent this from happening but this is a really old test.
kettanaito
changed the title
kettanaito
changed the title
Released: v0.31.0 🎉This has been released in v0.31.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Changes
responseevent listeners before finishing the response (emitting itsendevent). This affects both mocked and original responses (the approach is different for each).