Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ClientRequest): handle Headers without internal symbol #641

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(ClientRequest): handle Headers without internal symbol #641

merged 1 commit into from
Sep 20, 2024

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Sep 20, 2024 •
edited
Loading

Changes

  • Add handling for situations when a Headers instance has been constructed before the interceptor started recording the raw headers. Previously, threw this error:
TypeError: inferRawHeaders(...) is not iterable (cannot read property undefined)

We were trying to ...inferRawHeaders() on a Headers instance that had no kRawHeaders symbol set (the recording hasn't started yet).

@kettanaito kettanaito merged commit 0ec83fc into main Sep 20, 2024
2 checks passed
@kettanaito kettanaito deleted the fix/unrecorded-headers branch September 20, 2024 09:00
@kettanaito
Copy link
Member Author

Released: v0.35.8 🎉

This has been released in v0.35.8!

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

@TSDell2023 TSDell2023 mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kettanaito