fix(ClientRequest): prevent req.write() callbacks from being called twice on passthrough
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Dec 1, 2024
| * if `request.end()` was called within `request.write()`. | ||
| * @see https://github.com/mswjs/interceptors/issues/684 | ||
| */ | ||
| writeCall[2] = undefined |
There was a problem hiding this comment.
I decided to go with the replacement approach because it's simpler than introducing an internal symbol.
kettanaito
changed the title
req.write() callbacks from being called twice on passthrough
|
Thanks!
I forgot that |
mikicho
approved these changes
Dec 1, 2024
| * if `request.end()` was called within `request.write()`. | ||
| * @see https://github.com/mswjs/interceptors/issues/684 | ||
| */ | ||
| writeCall[2] = undefined |
|
Thanks for looking at this one! 🎉 |
Released: v0.37.2 🎉This has been released in v0.37.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormDataare broken) #684Changes
During the
flushWriteBuffer(), set the invoked callback on the write args toundefinedso it doesn't get called again (twice) during passthrough of requests that callrequest.end()within therequest.write()callback. The issue is only reproducible in that scenario and doesn't happen on sequential write/end calls.