Fix: Make sure MSW loader is resolved only when mocking is enabled #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kettanaito
reviewed
Jul 12, 2024
kettanaito
reviewed
Jul 12, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89
This PR finally solves the inconsistency issues that mswLoaders were trying to initially solve. Before, they were waiting for the service worker to be registered, but we later found out it wasn't enough. Thanks to @kettanaito the loaders should now wait properly.
I manually patched msw to take much longer to register, and Storybook waited and worked as intended with the changes from this PR.
📦 Published PR as canary version:
2.0.3--canary.157.8ab54e9.0✨ Test out this PR locally via:
npm install msw-storybook-addon@2.0.3--canary.157.8ab54e9.0 # or yarn add msw-storybook-addon@2.0.3--canary.157.8ab54e9.0