docs: fix jsdoc default value for worker url #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the JSDoc default value for the service worker URL on the `StartOptions` interface Actual default value is '/mockServiceWorker.js' but on JSDoc it was './mockServiceWorker.js'
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9443342:
|
kettanaito
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Such a nice find! Thank you for fixing this, @heitorlisboa 🎉 Welcome to contributors!
kettanaito
changed the title
Released: v0.48.0 🎉This has been released in v0.48.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the JSDoc default value for the service worker URL on the
StartOptionsinterface.Actual default value is
'/mockServiceWorker.js'(check here) but on JSDoc it was'./mockServiceWorker.js'.