Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support typescript 4.9, drop support for typescript 4.2, 4.3 #1467

Merged
merged 1 commit into from
Nov 18, 2022
Merged

feat: support typescript 4.9, drop support for typescript 4.2, 4.3 #1467

merged 1 commit into from
Nov 18, 2022

Conversation

wtchnm
Copy link
Contributor

@wtchnm wtchnm commented Nov 17, 2022

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 80c021a:

Sandbox Source
MSW React Configuration

"url-loader": "^4.1.1",
"webpack": "^5.68.0",
"webpack-dev-server": "^3.11.2"
},
"peerDependencies": {
"typescript": ">= 4.2.x <= 4.8.x"
"typescript": ">= 4.4.x <= 4.9.x"
Copy link
Member

@kettanaito kettanaito Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know how old TS 4.2/4.3 is? I wonder if it's safe to drop support for them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS 4.2 is 1 year and 9 months old, TS 4.3 is 1 year and 6 months old. According to the release notes, no breaking changes would block migration to TS 4.4.
See TS 4.3 breaking changes and TS 4.4 breaking changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking that up! That's lovely, let's drop their support and introduce 4.9.

Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for working on this, @wtchnm 👏

@kettanaito kettanaito changed the title feat: support typescript 4.9 feat: support typescript 4.9, drop support for typescript 4.2 - 4.4 Nov 18, 2022
@kettanaito kettanaito changed the title feat: support typescript 4.9, drop support for typescript 4.2 - 4.4 feat: support typescript 4.9, drop support for typescript 4.2, 4.3 Nov 18, 2022
@wtchnm
Copy link
Contributor Author

wtchnm commented Nov 18, 2022

Sure, thanks for your amazing work on this lib!

@kettanaito kettanaito merged commit af0277d into mswjs:main Nov 18, 2022
@wtchnm wtchnm deleted the feat/ts-49 branch November 18, 2022 13:47
@kettanaito
Copy link
Member

Released: v0.49.0 🎉

This has been released in v0.49.0!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

@andykenward
Copy link

@kettanaito Can you also do this for the msw@next 0.0.0-fetch.rc-1 ? I'm currently getting this npm error.

node : 16.18.1
npm: 8.19.2

$ npm install msw@next
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: msw@0.0.0-fetch.rc-1
npm ERR! Found: typescript@4.9.3
npm ERR! node_modules/typescript
npm ERR!   typescript@"4.9.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional typescript@">= 4.2.x <= 4.8.x" from msw@0.0.0-fetch.rc-1
npm ERR! node_modules/msw
npm ERR!   msw@"0.0.0-fetch.rc-1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: typescript@4.8.4
npm ERR! node_modules/typescript
npm ERR!   peerOptional typescript@">= 4.2.x <= 4.8.x" from msw@0.0.0-fetch.rc-1
npm ERR!   node_modules/msw
npm ERR!     msw@"0.0.0-fetch.rc-1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@kettanaito
Copy link
Member

Hey, @andykenward. Sure, will update that release as well when I have a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants