Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use EventTarget-based event emitter #1522

Merged
merged 2 commits into from
Jan 17, 2023
Merged

fix: use EventTarget-based event emitter #1522

merged 2 commits into from
Jan 17, 2023

Conversation

chrisguttandin
Copy link
Collaborator

@chrisguttandin chrisguttandin commented Jan 17, 2023

This PR intended to update strict event emitter to the latest version.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7cfc73:

Sandbox Source
MSW React Configuration

@kettanaito kettanaito changed the title Update strict event emitter fix: use EventTarget-based event emitter Jan 17, 2023
@kettanaito
Copy link
Member

@chrisguttandin, thanks for this update! Looks awesome.

Please, have you by any chance noticed if any of MSW dependencies use an older version of strict-event-emitter? I'm curious about the Interceptors package in particular.

@chrisguttandin
Copy link
Collaborator Author

Running npm ls strict-event-emitter only reveals @mswjs/interceptors as another user of strict-event-emitter.

This is what it looks like with this PR.

msw@0.49.2
├─┬ @mswjs/interceptors@0.17.5
│ └── strict-event-emitter@0.2.4
└── strict-event-emitter@0.4.3

@kettanaito
Copy link
Member

Nice! I think that shouldn't be the issue since the old strict-event-emitter had problems in the browser. It always worked fine in Node because it was originally based off the native EventEmitter (which is not a thing in the browser).

This should have us good to go!

@kettanaito kettanaito merged commit 6a94b8c into mswjs:main Jan 17, 2023
@kettanaito
Copy link
Member

Released: v0.49.3 🎉

This has been released in v0.49.3!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

@dustinmyers
Copy link

This may be causing errors now - see #1539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update strict-event-emitter to at least v0.3.x to avoid implicit dependency on Node.js type definitions.
3 participants