Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--runInBand
flag from unit and integration test commands.--max_old_space_size=8000
cap on the integration tests (previously added due to spawning WDS on each test and ts compiler causing a memory heap).Motivation
Current CI takes a lot of time to run, decreasing the iteration speed for the changes. Integration tests alone take about 6m 30s to run, not taking the workspace attachment into account (ref).
History
The
--runInBand
flag was added to prevent some leaking state between tests. It might have been related to the old testing setup that we don't have anymore, or to #474. I didn't see any problems running parallel tests locally.Benchmarks