Adds a NodeJS usage test #4
Conversation
|
ah, I have to rebase the branch on top of current mswj:master, not just Aprillion:master (done) |
src/LiveStorage.node.test.ts
Outdated
|
|
||
| test('REAME example', () => { | ||
| const scenario = () => { | ||
| // TODO: BroadcastChannel is not available in Node 14 nor `jsdom` environment |
There was a problem hiding this comment.
Would you be interested if I pushed a work-in-progress state I've been working on, where we don't invoke things not available in NodeJS? You could then continue with converting a class into a singleton or discuss any other way to implement storage persistency in NodeJS.
There was a problem hiding this comment.
probably yes, not sure when I would find time to think about it properly...
There was a problem hiding this comment.
Absolutely no hurry in this. I've pushed my progress to the master: 994505d
There was a problem hiding this comment.
rebased and using the public property value to make the assertion for now
FTR: the test is passing now, at least on Windows Node v14.13.1 :D
There was a problem hiding this comment.
IMHO this.value should be enough for storage persistence in Node for now,, enforcing singletons can be discussed in a separate issue whether needed (probably nice to have, but not sure if worth the complexity - if I am inspired by a simple idea to enforce single instance per id, I can write a separate PR later)
* which currently fails => need to update code..
failing test for example from readme: mswjs/msw#254 (comment)