Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgconfig switch #7263

Closed
lazka opened this issue Nov 10, 2020 · 8 comments · Fixed by #7313
Closed

pkgconfig switch #7263

lazka opened this issue Nov 10, 2020 · 8 comments · Fixed by #7313

Comments

@lazka
Copy link
Member

lazka commented Nov 10, 2020

I've looked into if we can move from pkg-config to pkgconf for mingw as well.

Current actions:

@okhlybov
Copy link
Contributor

What is the purpose for this switch? Is pkgconf any better than pkg-config?

@lazka
Copy link
Member Author

lazka commented Nov 12, 2020

See http://pkgconf.org/features.html (for pkg-config use the git column, most of it isn't that relevant though)

Nice things:

@okhlybov
Copy link
Contributor

okhlybov commented Nov 12, 2020

What does the switch mean for the package maintainers?
Will it be the all-in switch or both tools are expected to be coinstalled?
Will pkgconf come into the base-devel or it should be explicitly depended upon?

@lazka
Copy link
Member Author

lazka commented Nov 12, 2020

What does the switch mean for the package maintainers?

Ideally, no changes.

Will it be the all-in switch or both tools are expected to be coinstalled?

all in, pkgconf provides the same executables

Will pkgconf come into the base-devel or it should be explicitly depended upon?

It will be in base-devel instead of pkg-config

See msys2/MSYS2-packages#2197 for a similar switch

@okhlybov
Copy link
Contributor

all in, pkgconf provides the same executables

So we continue to use the pkg-config executable now coming from the pkgconf package, right?

@lazka
Copy link
Member Author

lazka commented Nov 12, 2020

yes

lazka added a commit to lazka/MINGW-packages that referenced this issue Nov 22, 2020
Instead of normalizing paths at the end, do it when adding them to
to the pc file, to not break backslashes for used for escaping.

Also fix version field validation.

With this the meson test suite passes.

See msys2#7263
lazka added a commit to lazka/MINGW-packages that referenced this issue Nov 22, 2020
Instead of normalizing paths at the end, do it when adding them to
to the pc file, to avoid breaking backslashes used for escaping.

Also fix version field validation.

With this the meson test suite passes.

See msys2#7263
@lazka
Copy link
Member Author

lazka commented Nov 22, 2020

The meson test suite now passes with the latest fixes.

I think this is ready.

larskanis added a commit to oneclick/rubyinstaller2 that referenced this issue Apr 17, 2021
MSYS2 replaced pkg-config by pkgconf in msys2/MINGW-packages#7263 .
We follow this move.

Fixes #222
@rnicolas
Copy link

Just to cite that if you were using pkg-config (or you read any tutorial where pkg-config is cited), and you want to use pkgconf instead, you might need to replace pkg-config for pkgconf .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants