-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: Add release description #12570
Conversation
It might be better to match this closer to the output of I do see that rustc --version
rustc 1.61.0 (fe5b13d68 2022-05-18) but I don't think the commit hash really matters for us since we are using a tarball rather than a checkout |
rustc currently just includes basic version information when built via tarball (ie no commit hash and no commit date), but there is a pending PR that addresses this -> rust-lang/rust#100557 |
Tell me what you want. I have no opinion. |
The description can be any string. |
Perhaps something like, rustc --version
rustc 1.62.1 (2022-08-17 Built by MSYS2 project) or exposing which subsystem it was built for along with date and ownership rustc --version
rustc 1.62.1 (mingw64 Rev${pkgrel} 2022-08-17 Built by MSYS2 project) or somehow (I don't think moving the version to the end is possible) to bring it closer to rustc --version
rustc (Rev${pkgrel}, Built by MSYS2 project on 2022-08-17) 1.62.1 Just some ideas on how to put some things together, but I would say it's based on how easy it is to put them there, we probably want to convey the fact that this build is specifically from msys2 rather than an official build from the Rust Language organization for Windows so that way upstream devs can except that it might not be "pristine" and could have additional patches on top of it. |
I can do exactly like gcc:
Without a date. Threre is no readily available date variable afaik. |
You could maybe use - --release-description="Rev${pkgrel}, Built by MSYS2 project" \
+ --release-description="Rev${pkgrel}, Built by MSYS2 project on $(date +%Y-%m-%d)" \ |
Do we really want the date ? |
I don't think date would be that useful, especially since that information should be somewhat tied to As for possibly including subsystem information, are there any patches that are only applied to a specific subsystem? If yes then it might be worth including, though I guess the subsystem information could also be derived from the executable itself. But these are just my two cents, I mainly brought up this issue to point out the fact that the release description is currently empty, so I don't have any particular preference what that description should look like, |
I don't know if reproducible builds are a thing for us but many distros stopped inserting dates because it's not easily reproducible. |
The reproducible builds way would be https://reproducible-builds.org/docs/source-date-epoch/#bash--posix-shell |
Let's merge the minimal version, until some has an actual use case for more information. |
fixes #12569