-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mingw-w64-crt: create dummy ssp libs #13405
Conversation
package-grokker shows that these packages should be rebuilt:
|
Couldn't we just remove the libssp.a/libssp.dll.a from gcc/libssp, so there is no conflict, and then rebuild things afterwards when we want? Or do you think making the full transition in one go is easier? |
That's what I was going to do. |
but then you don't need/want conflicts/replaces/provides here, since there is no conflict and replacing would remove the .dll breaking all dependencies. |
7212614
to
41ebec4
Compare
41ebec4
to
0e4e70b
Compare
OK to merge? |
one sec. this isn't compatible with #13410, it removes the DLL while this one here keeps it. Since my idea to smooth the transition is maybe a bit too involved I guess we can just do the rebuilds. I'll revert my suggestions made here and start rebuilds with libssp completely removed.. |
Edit: It won't work, crt will conflict with gcc |
#13410 should be merged before this one to avoid conflict between crt and gcc. |
I will try to test building some libssp packages with this and #13410, to see if it actually works as advertised. |
If we are going to remove |
yeah, some users might still reference it though.. but not sure how realistic that is |
I forgot about that! |
ok, there was one confusion in chat @mati865 thought that with the crt providing the libssp stuff building with "-lssp" or "-fstack-protector-strong" would end up not actually linking against the DLL, but that isn't true for some reason (both gcc and clang envs).. documenting here for future reference. |
but still provide the .DLL. In combination with msys2#13405 this will make all rebuilds link the libssp stuff against the crt while keeping existing packages already linking against the .DLL working until we rebuild them. This is an alternative to msys2#13410
No description provided.