Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang: Build with PGO #19256

Merged
merged 1 commit into from
Dec 3, 2023
Merged

clang: Build with PGO #19256

merged 1 commit into from
Dec 3, 2023

Conversation

MehdiChinoune
Copy link
Collaborator

@MehdiChinoune MehdiChinoune commented Dec 3, 2023 •
edited
Loading

enabled only for clang64 and clangarm64

@MehdiChinoune
Copy link
Collaborator Author

some tests with my small project (C++):

w/ PGO:
2m38.229s
2m39.065s
2m41.254s

w/o PGO:
3m8.305s
3m8.250s
3m7.180s

speedup~=-15%
Impressive!

@MehdiChinoune MehdiChinoune marked this pull request as ready for review December 3, 2023 13:03
@MehdiChinoune
Copy link
Collaborator Author

Some other tests:

HarfBuzz (C++):
w/ PGO: 1m10.877s; 1m10.778s; 1m10.356s
w/o PGO: 1m27.521s; 1m27.103s; 1m28.288s
speedup~=-19%

GTK3 (C):
w/ PGO: 2m45.776s; 2m43.960s; 2m43.853s
w/o PGO: 3m7.433s; 3m9.390s; 3m13.088s
speedup~=-13%

@MehdiChinoune MehdiChinoune merged commit 4dd91d1 into msys2:master Dec 3, 2023
7 of 8 checks passed
@MehdiChinoune MehdiChinoune deleted the clang-pgo branch December 3, 2023 18:09
@lazka
Copy link
Member

lazka commented Dec 4, 2023 •
edited
Loading

I even get -20% for gtk and -27% for harfbuzz.

@lazka
Copy link
Member

lazka commented Dec 4, 2023

The 5h 44m build time is a bit on high end, let's hope future clang versions don't hit the limit :)

@MehdiChinoune
Copy link
Collaborator Author

The 5h 44m build time is a bit on high end, let's hope future clang versions don't hit the limit :)

Future clang versions will be built by PGO'ed clang, It should take less time.

@Biswa96
Copy link
Member

Biswa96 commented Dec 4, 2023

I even get -20% for gtk and -27% for harfbuzz.

Are those comparison of compile times or something else?

@lazka
Copy link
Member

lazka commented Dec 4, 2023 •
edited
Loading

time ninja (without ccache)

@zamazan4ik zamazan4ik mentioned this pull request Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MehdiChinoune @lazka @Biswa96