Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: don't generate debuginfo on i686 #21581

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

ognevny
Copy link
Collaborator

@ognevny ognevny commented Aug 6, 2024

it takes too much memory to do that

@ognevny ognevny force-pushed the rust-remove-debug-i686 branch from 1808787 to 1cf318d Compare August 6, 2024 19:13
@ognevny
Copy link
Collaborator Author

ognevny commented Aug 6, 2024

I also backported change from #21579

@lazka lazka merged commit 35ac9e3 into msys2:master Aug 7, 2024
7 of 8 checks passed
@ognevny ognevny deleted the rust-remove-debug-i686 branch August 7, 2024 06:19
@jeremyd2019
Copy link
Member

I think that makepkg is stripping rust, so I don't know what good building with extra debug info does when it's just stripped back out when packaging. Maybe you want to enable options=('strip' 'debug') and get split debug packages? Note: if you try that, please check that CFLAGS are still what you expect, I am kind of concerned doing that might change optimization.

@ognevny ognevny mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants